Update FUNDING.json #7304
Merged
Update FUNDING.json #7304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had issue with the previous multisig address so we decided to create a specifi EOA owned by Redwan and will share the PK or transfer the funds to Web3js multisig after.
Redoudou
requested review from
avkos,
jdevcs,
luu-alex and
Muhammad-Altabba
as code owners
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: cd1018e | Previous: dcd9d6a | Ratio |
|---|---|---|---|
processingTx |
21957 ops/sec (±5.87%) |
22379 ops/sec (±6.21%) |
1.02 |
processingContractDeploy |
36478 ops/sec (±8.20%) |
39186 ops/sec (±7.73%) |
1.07 |
processingContractMethodSend |
14890 ops/sec (±8.64%) |
14923 ops/sec (±8.63%) |
1.00 |
processingContractMethodCall |
26903 ops/sec (±7.97%) |
25900 ops/sec (±8.10%) |
0.96 |
abiEncode |
42134 ops/sec (±7.31%) |
42051 ops/sec (±5.40%) |
1.00 |
abiDecode |
29569 ops/sec (±5.93%) |
29557 ops/sec (±8.36%) |
1.00 |
sign |
1494 ops/sec (±3.55%) |
1507 ops/sec (±3.35%) |
1.01 |
verify |
364 ops/sec (±0.52%) |
362 ops/sec (±0.53%) |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7304 +/- ##
=======================================
Coverage 94.44% 94.44%
=======================================
Files 216 216
Lines 8463 8463
Branches 2339 2339
=======================================
Hits 7993 7993
Misses 470 470
Flags with carried forward coverage won't be shown. Click here to find out more. |
luu-alex
approved these changes
Oct 4, 2024
danforbes
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had issue with the previous multisig address so we decided to create a specifi EOA owned by Redwan and will share the PK or transfer the funds to Web3js multisig after.
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.